Add GeoJSON endpoints for shelters and distribution points #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omnilord
requested changes
Oct 20, 2018
There was a problem hiding this comment.
The actual code looks like it works. @nihonjinrxs, Check Slack, I left a message for you there about something else.
db/structure.sql
Outdated
| @@ -201,10 +202,10 @@ CREATE TABLE public.distribution_points ( | |||
| updated_by character varying, | |||
| notes character varying, | |||
| source character varying, | |||
| longitude double precision, | |||
| latitude double precision, | |||
| longitude character varying, | |||
There was a problem hiding this comment.
There isn't an accompanying migration for this particular change and I'm not sure why this would change this way. Shelters has double precision for both of these fields which seems to be the standard for latitude and longitude.
There was a problem hiding this comment.
Yeah, not sure why this is here either. I'll push a commit to remove this change.
|
Saw the note in Slack. Thanks. OK to merge, then? |
omnilord
approved these changes
Oct 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the following API endpoints:
/api/v1/shelters/geo.json/api/v1/distribution_points/geo.jsonBoth support filters as with the base routes, and generate GeoJSON output.
Tests are also included.
Closes #44 when merged.