Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu cleanup #43

Merged
merged 1 commit into from
Oct 23, 2018
Merged

Menu cleanup #43

merged 1 commit into from
Oct 23, 2018

Conversation

omnilord
Copy link
Collaborator

I've created a PR for this to start a small discussion about cleaning up the Navbar a bit since with adding the Archived lists for Shelters and PODs really made it look fairly unwieldy on a desktop.

This PR adds 'menu' partials to each resource type page (Shelters, PODs, Needs) that sits under the navbar. It needs to be groomed for UI/UX and Styling, but it should be functional otherwise.

@nihonjinrxs
Copy link
Member

I think it's important to note that the large majority of these menu items are only visible to admins.

That said, I think it would likely be better to have dropdowns for the more advanced features, so that, for example, for shelters, you'd have something like:

  • Shelters -> /shelters
    • Outdated Shelter Records -> /shelters/outdated
    • Archived Shelter Records -> /shelters/archived
    • Download as CSV -> /shelters.csv

We'd likely also want to have the ability to have calls to action in the top-level menu and highlighted. For example, with the new "Make one call" feature we're discussing in #15 we'd likely want "Help Call Shelters" as a highlighted call to action in the top-level menu.

In any case, more discussion on this is definitely a good idea before moving forward.

@omnilord omnilord force-pushed the menu-cleanup branch 9 times, most recently from 4c0c6c5 to 6acb710 Compare September 25, 2018 05:05
@omnilord
Copy link
Collaborator Author

I popped the commit out for the in-page links and rolled up a dropdown POC and it looks to work well in Chrome, Safari, and Firefox. I don't have access to Edge or IE at the moment. Not sure how to make this look nice and responsive on mobile devices, however, since we don't have something like Bootstrap included.

@omnilord omnilord force-pushed the menu-cleanup branch 4 times, most recently from 7f84e40 to ec2e8e2 Compare October 17, 2018 06:39
@nihonjinrxs nihonjinrxs added the enhancement New feature or request label Oct 21, 2018
@nihonjinrxs
Copy link
Member

This looks pretty good as is. @omnilord can you verify that it covers all the stuff that's happened since last month? If so, ready to merge.

@omnilord
Copy link
Collaborator Author

Everything should be up to date. I've been keeping it up to head so it was ready to merge when someone had a chance to re-review it.

@omnilord omnilord merged commit fa1a25e into hurricane-response:master Oct 23, 2018
@omnilord omnilord deleted the menu-cleanup branch October 23, 2018 22:59
@omnilord omnilord changed the title [WIP: needs discussion] Menu cleanup Menu cleanup Oct 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants