[Depends on #34] Fix tests (and production API 500 errors, too! Yikes!) #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nihonjinrxs
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes 2 of the 5 errors happening when tests are run. In addition, I found that using filters on the shelters API endpoint after the refactoring of the controller in #22 is generating 500 errors in production. (For example, see: https://hurricane-florence-api.herokuapp.com/api/v1/shelters?accepting=true)
The remaining 3 errors are related to outdated fixtures for the Amazon AWS Product Advertising API, which requires that you first be an Amazon Associate. Since our devs likely don't have the ability to do this, those tests will always fail until someone with the following records new fixtures for these tests:
:allon this repoAre we using this feature of the API? If not, we should probably have an issue to feature-flag this one so it can be turned off.
@GovInTrenches @miklb Since this fixes production 500 errors, we should merge and deploy this quickly.