Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Delete Shelter in Admin UI #54

Closed
miklb opened this issue Oct 10, 2018 · 1 comment
Closed

Feature: Delete Shelter in Admin UI #54

miklb opened this issue Oct 10, 2018 · 1 comment
Assignees
@omnilord
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@miklb
Copy link
Contributor

miklb commented Oct 10, 2018

Currently I do not see an admin UI to delete a shelter. Only archive. Not sure what original design decision on that was.
@miklb miklb added the enhancement New feature or request label Oct 10, 2018
@omnilord
Copy link
Collaborator

Looks like Destroy just wasn't coded for any of the resources. The action is there, just empty. A good idea for implementing this would be to add a "trash" table and insert any deleted rows into the trash table so if someone does delete a shelter that shouldn't be, we still have the record.

@omnilord omnilord added the good first issue Good for newcomers label Oct 12, 2018
@omnilord omnilord self-assigned this Oct 13, 2018
omnilord added a commit to omnilord/florence-api that referenced this issue Oct 14, 2018
@omnilord
Adding trash and making Shelters and Distribution Points 'trashable' …
5c0d0f9 
…so that they can be 'deleted'

Closes hurricane-response#54
@omnilord omnilord mentioned this issue Oct 14, 2018
Merged
omnilord added a commit to omnilord/florence-api that referenced this issue Oct 14, 2018
@omnilord
Adding trash and making Shelters and Distribution Points 'trashable' …
3757006 
…so that they can be 'deleted'

Closes hurricane-response#54
omnilord added a commit to omnilord/florence-api that referenced this issue Oct 15, 2018
@omnilord
Adding trash and making Shelters and Distribution Points 'trashable' …
0389853 
…so that they can be 'deleted'

Closes hurricane-response#54
@miklb miklb closed this as completed in #64 Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@omnilord omnilord

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@miklb @omnilord