Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: More explicit peerDep on gatsby #69

Merged
merged 1 commit into from
Apr 8, 2021
Merged

fix: More explicit peerDep on gatsby #69

merged 1 commit into from
Apr 8, 2021

Conversation

LekoArts
Copy link
Contributor

@LekoArts LekoArts commented Apr 8, 2021

Hello @hupe1980, Gatsby maintainer here 👋
First and foremost, thanks for creating the plugin & maintaining it. Much appreciated!

While looking at your plugin I noticed that the peerDependency on gatsby is set incorrectly. We're in the process of providing more helpful information on the /plugins page of our website and for that we need plugins to set their peerDependencies correctly/more specific.

At the moment you say that any version (v4, v5, v6, etc.) will work with this even when in between we'd introduce breaking changes.

Making it more explicit is the safer choice (in the future you'll be able to mark breaking changes with explicit version ranges) and will allow us to display the plugin as compatible to versions X, Y, Z.

Thanks!

@hupe1980 hupe1980 self-requested a review April 8, 2021 10:21
Copy link
Owner

@hupe1980 hupe1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, thx for the hint!

@hupe1980 hupe1980 merged commit c02830f into hupe1980:master Apr 8, 2021
@LekoArts LekoArts deleted the patch-1 branch April 8, 2021 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants