Allow to provide rich object props to StylesProvider #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: Added ability to define custom insertion point closes hupe1980#19 feat: added ability to inject style tags at custom point in head also updated README to explain how it is done closes hupe1980#19 fix: add option to specify jss config closes hupe1980#19 .gitignore fix fix: changed config to match stylesProvider props .gitignore fix feat: added ability to inject style tags at custom point in head also updated README to explain how it is done closes hupe1980#19 fix: add option to specify jss config closes hupe1980#19 .gitignore fix fix: changed config to match stylesProvider props
1. fixed unit tests with jest virtual mocking 2. Made sure all quotations use backtick (single ticks for imports) 3. Made sure the style sheet generated with gatsby-ssr.js are passed the same options as the style sheet added by gatsby-browser.js
oliviertassinari
force-pushed
the
custom-insertion-point
branch
9 times, most recently
from
b86c628
to
db12bb3
Compare
oliviertassinari
force-pushed
the
custom-insertion-point
branch
from
db12bb3
to
1e4259a
Compare
oliviertassinari
changed the title
hupe1980
approved these changes
Jun 25, 2019
There was a problem hiding this comment.
@oliviertassinari @magnusriga Nice job!
@magnusriga Do you have any comments?
e2e-tests/development-runtime/plugins/gatsby-plugin-top-layout/top-layout.js
Outdated
Show resolved
Hide resolved
|
I have not had the chance to review the new PR due to another project at work. I am sure you did a fine job wrapping it up. Looking forward to testing it. Any idea why it GitHub didn't list me as contributor @oliviertassinari / @hupe1980 ? I was hoping to tick that box, as up until now I had only published my own projects and not collaborated on an open source one :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new
pathToStylesProvideroption. The is a string that describes the location of a file that returns the props to apply to the StylesProvider component.Closes #20
Closes #19