Distribute integration test to single test files #455
Conversation
…ntegration-test-to-single-test
|
We could ship part of them and migrate the rest in the follow PRs! Just for reduce the pressure of reviewing 🤣 |
test/testing-utils.ts
Outdated
| // Additional files to remove inside the fixtures directory | ||
| // e.g. tsconfig.json | ||
| if (filesToRemove) { | ||
| for (const file of filesToRemove) { |
There was a problem hiding this comment.
Added filesToRemove to createTest to remove additional files created during tests (e.g. tsconfig.json)
There was a problem hiding this comment.
Is that possible to do it in beforeEach or beforeAll in the actual test? That's also why I want to refactor the tests to have less options
There was a problem hiding this comment.
I see. Will remove it thanks!
There was a problem hiding this comment.
If you don't mind, could you tell me why you're not using temporary dirs?
There was a problem hiding this comment.
I want to do e2e at the begining, and linked bunchee there, so it can be seaprate from the installed packages in current project. but it's a long term refactor work
Co-authored-by: Jiachi Liu <[email protected]>
…nually Co-authored-by: Jiachi Liu <[email protected]>
| @@ -21,6 +20,8 @@ describe('integration', () => { | |||
| '#!/usr/bin/env node', | |||
| ) | |||
| } | |||
|
|
|||
| await deleteFile(`${__dirname}/fixtures/tsconfig.json`) | |||
There was a problem hiding this comment.
Kinda forgot the reason why we need to remove them here?
I though if we have 2 integration tests share the same directory, any required to delete files can be remove in the beforeEach/afterEach jest lifecycle.
But not sure if we still need them here for single test?
There was a problem hiding this comment.
My bad, for a single test, absolutely not.
Co-authored-by: Jiachi Liu <[email protected]>
| import { readFile } from 'fs/promises' | ||
| import { createIntegrationTest, deleteFile, existsFile } from '../../utils' | ||
|
|
||
| afterEach(async () => { |
There was a problem hiding this comment.
we probably don't need it here, for single test
| await deleteFile(`${__dirname}/fixtures/tsconfig.json`) | ||
| }) | ||
|
|
||
| describe('integration', () => { |
There was a problem hiding this comment.
better to use different names, like "integration - cts" for describe() name, then give it("should ..") to describe the expectation
There was a problem hiding this comment.
Got it! Do you want me to resolve it on this PR or other?
There was a problem hiding this comment.
Ye not blocking, can follow up later!
This PR initiated a migration of single-file integration tests to each have their own test files.
executeBuncheefromcli/utilstotesting-utilsfilesToRemoveparam to be received oncreateTestto remove files after the tests liketsconfig.json.The migration range of this PR covers:
Resolves #449