implement optional time, frame, dump period limits (WIPish) #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also verbose timing for loading phases.
dormando
force-pushed
the
startlimits
branch
from
033dae5
to
18a4dd6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also verbose timing for loading phases.
I guess WIP, brain's not giving me good work today. I'm still slowly adapting to golangisms and there's some obvious weirdness (starting/stopping ticker, doubled default). I also want to add an option to limit the number of CPU's used and seed random numbers, but those're pulled from deeper down.
Probably better to end up with an options structure for the "renderer" that render.Iterative takes, which includes time/frame/cpu/etc. Have to just decide where the doubled default goes.
still spending most of my time learning rendering, but want to keep up with small changes :)