-
-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚀 Migrate Components to Melt UI #150
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ff4df5c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This was referenced Aug 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update (2023/08/15) - We’re wrapping up the CLI (thanks @AdrianGonz97) and we’ll be ready for takeoff. The headless primitives inherit just about all behavior/options from Melt with a few minor qualify of life differences when working with components. I still need to create a doc site for those but won’t have the community waiting before we publish these changes.
——
To reduce a lot of the unnecessary boilerplate & provide a better overall DX, I've decided to wrap the Melt UI builders in "primitives components", which will be similar to Radix UI, and will be published as the core dependency of
shadcn-svelte
.I know I know, "We tried that and it didn't work!", but that's only because we didn't have Melt under the hood.
huntabyte/primitives
I'll also track the status of each here so that you have a general idea of how far along we are.
Note: These are only the components that rely on a headless lib, the others are fine :)
Things:
Closes: #160 #125 #154 #148 #145 #144 #114 #127 #14