-
-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(next): Refactor PM
comps to use package-manager-detector
#1491
Conversation
|
|
I almost want to open up an issue on edit: |
I don't think this will be necessary now that #1487 is merged. |
I think you are right let me try and reproduce their issue without the new steps before closing it! |
Yeah I can't reproduce it with the latest version. I still think this has some good changes to the PM components but unless something changes with |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
run dev server once
to SvelteKit installation instructionPM
components to use package-manager-detector
Changing this just to refactor the PM component. All I had to do to make it work was use type only imports from the root of the project so that it doesn't load |
CleanShot.2024-11-17.at.13.41.44.mp4Is this actually how scripts are executed with bun or should it be |
Yeah you're right I'm either using resolve command wrong or there's a bug I can hopefully find the time to take a look today if not tomorrow |
Okay so actually bunx is a shorthand for bun x But I think pretty much everyone just says bunx so maybe I should just make an exception for bun and that command? |
@AdrianGonz97 what are your feelings about this lol |
We're going to keep it as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
PM
components to use package-manager-detectorPM
comps to use package-manager-detector
Fixes #1474
run dev server once
to installation instruction<PMRun/>
componentpackage-manager-detector
so adding new commands is easier.