-
-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(next): Migration instruction #1446
Conversation
|
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this. Just a few minor things here, I can update them later if you don't have the time atm!
Thanks should be back to fix these in around 15 minutes |
Co-authored-by: Hunter Johnston <[email protected]>
Co-authored-by: Hunter Johnston <[email protected]>
Co-authored-by: Hunter Johnston <[email protected]>
Co-authored-by: Hunter Johnston <[email protected]>
This is a great guide! I do have one mild suggestion for wording within this guide. Instead of saying "We got rid of svelte-headless-table in favor of @tanstack/table-core", I suggest stating "svelte-headless-table has been removed in favor of @tanstack/table-core." This cleans up the verbiage a little bit in my opinion |
I agree that sounds better. |
@huntabyte should I just go ahead and change the instruction to use the |
Good to go now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
For whatever reason #1437 wasn't closed by this PR. |
Adds documentation for migrating from Svelte 4 -> Svelte 5. Aims to fix #1437.
<PMRemove/>
component for the docsOpening this as a draft right now to collect feedback so let me know what you think.
Right now this PR assumes #1421 merges with update changes otherwise
add
command should be used.