Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(next): Migration instruction #1446

Merged
merged 16 commits into from
Nov 8, 2024

Conversation

ieedan
Copy link
Contributor

@ieedan ieedan commented Nov 5, 2024

Adds documentation for migrating from Svelte 4 -> Svelte 5. Aims to fix #1437.

  • Needed to add a <PMRemove/> component for the docs

Opening this as a draft right now to collect feedback so let me know what you think.

Right now this PR assumes #1421 merges with update changes otherwise add command should be used.

Copy link

changeset-bot bot commented Nov 5, 2024

⚠️ No Changeset found

Latest commit: 6dba6a5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 5, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
shadcn-svelte ✅ Ready (View Log) Visit Preview 6dba6a5

Copy link
Owner

@huntabyte huntabyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. Just a few minor things here, I can update them later if you don't have the time atm!

sites/docs/src/content/migration/svelte-5/index.md Outdated Show resolved Hide resolved
sites/docs/src/content/migration/svelte-5/index.md Outdated Show resolved Hide resolved
sites/docs/src/content/migration/svelte-5/index.md Outdated Show resolved Hide resolved
sites/docs/src/content/migration/svelte-5/index.md Outdated Show resolved Hide resolved
@ieedan
Copy link
Contributor Author

ieedan commented Nov 5, 2024

Thanks should be back to fix these in around 15 minutes

ieedan and others added 4 commits November 5, 2024 08:34
Co-authored-by: Hunter Johnston <[email protected]>
Co-authored-by: Hunter Johnston <[email protected]>
Co-authored-by: Hunter Johnston <[email protected]>
Co-authored-by: Hunter Johnston <[email protected]>
@JYLN
Copy link

JYLN commented Nov 5, 2024

This is a great guide! I do have one mild suggestion for wording within this guide. Instead of saying "We got rid of svelte-headless-table in favor of @tanstack/table-core", I suggest stating "svelte-headless-table has been removed in favor of @tanstack/table-core." This cleans up the verbiage a little bit in my opinion

@ieedan
Copy link
Contributor Author

ieedan commented Nov 5, 2024

This is a great guide! I do have one mild suggestion for wording within this guide. Instead of saying "We got rid of svelte-headless-table in favor of @tanstack/table-core", I suggest stating "svelte-headless-table has been removed in favor of @tanstack/table-core." This cleans up the verbiage a little bit in my opinion

I agree that sounds better.

@ieedan
Copy link
Contributor Author

ieedan commented Nov 7, 2024

@huntabyte should I just go ahead and change the instruction to use the add command instead? If #1421 merges I can come back and fix that another time.

@ieedan ieedan marked this pull request as ready for review November 7, 2024 22:45
@ieedan
Copy link
Contributor Author

ieedan commented Nov 7, 2024

@huntabyte should I just go ahead and change the instruction to use the add command instead? If #1421 merges I can come back and fix that another time.

Good to go now!

Copy link
Owner

@huntabyte huntabyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@huntabyte huntabyte merged commit fd144a2 into huntabyte:next Nov 8, 2024
4 checks passed
@ieedan
Copy link
Contributor Author

ieedan commented Nov 8, 2024

For whatever reason #1437 wasn't closed by this PR.

@ieedan ieedan deleted the migration-instruction branch November 8, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants