Skip to content

Commit

Permalink
fix: Fixed WAF Reliability validation in `avm/res/network/public-ip-a…
Browse files Browse the repository at this point in the history
…ddress` (Azure#1367)

## Description

Fixes failing WAF Reliability validation

<!--
>Thank you for your contribution !
> Please include a summary of the change and which issue is fixed.
> Please also include the context.
> List any dependencies that are required for this change.

Fixes Azure#123
Fixes Azure#456
Closes Azure#123
Closes Azure#456
-->

## Pipeline Reference

<!-- Insert your Pipeline Status Badge below -->

| Pipeline |
| -------- |
|
[![avm.res.network.public-ip-address](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.network.public-ip-address.yml/badge.svg?branch=users%2Fkrbar%2FpipWAF)](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.network.public-ip-address.yml)
|

## Type of Change

<!-- Use the check-boxes [x] on the options that are relevant. -->

- [ ] Update to CI Environment or utlities (Non-module effecting
changes)
- [x] Azure Verified Module updates:
- [ ] Bugfix containing backwards compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [ ] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [x] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [ ] Update to documentation

## Checklist

- [x] I'm sure there are no other open Pull Requests for the same
update/change
- [x] I have run `Set-AVMModule` locally to generate the supporting
module files.
- [x] My corresponding pipelines / checks run clean and green without
any errors or warnings

<!-- Please keep up to day with the contribution guide at
https://aka.ms/avm/contribute/bicep -->
  • Loading branch information
krbar authored Mar 21, 2024
1 parent 07951ad commit 59929d6
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 4 deletions.
8 changes: 8 additions & 0 deletions avm/res/network/public-ip-address/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -929,6 +929,14 @@ A list of availability zones denoting the IP allocated for the resource needs to

- Required: No
- Type: array
- Default:
```Bicep
[
'1'
'2'
'3'
]
```


## Outputs
Expand Down
6 changes: 5 additions & 1 deletion avm/res/network/public-ip-address/main.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,11 @@ param publicIpPrefixResourceId string?
param publicIPAllocationMethod string = 'Static'

@description('Optional. A list of availability zones denoting the IP allocated for the resource needs to come from.')
param zones array?
param zones array = [
'1'
'2'
'3'
]

@description('Optional. IP address version.')
@allowed([
Expand Down
10 changes: 7 additions & 3 deletions avm/res/network/public-ip-address/main.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.25.53.49325",
"templateHash": "1322777943943789546"
"version": "0.26.54.24096",
"templateHash": "11299369930230398843"
},
"name": "Public IP Addresses",
"description": "This module deploys a Public IP Address.",
Expand Down Expand Up @@ -318,7 +318,11 @@
},
"zones": {
"type": "array",
"nullable": true,
"defaultValue": [
"1",
"2",
"3"
],
"metadata": {
"description": "Optional. A list of availability zones denoting the IP allocated for the resource needs to come from."
}
Expand Down

0 comments on commit 59929d6

Please sign in to comment.