test: Do not hide the original throwable stack trace when failing to parse a file #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parse a file When a spec file could not be parsed, a `self::fail()` was used instead of letting the throwable bubble up. This was done to know which fail failed to parsed. The implementation however, is faulty as if an exception is thrown, there is no stack trace. This is especially annoying when the throwable may not be thrown due to an invalid spec file but due to the way this file is parsed (i.e. code within the `PhpScoperSpecTest`). This PR introduces a new exception which will contain the previously thrown exception but will also include a more friendly message to easily know for which file this was caused.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a spec file could not be parsed, a
self::fail()was used instead of letting the throwable bubble up. This was done to know which fail failed to parsed.The implementation however, is faulty as if an exception is thrown, there is no stack trace. This is especially annoying when the throwable may not be thrown due to an invalid spec file but due to the way this file is parsed (i.e. code within the
PhpScoperSpecTest).This PR introduces a new exception which will contain the previously thrown exception but will also include a more friendly message to easily know for which file this was caused.