-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add finders #89
Add finders #89
Conversation
Closes humbug#84.
Not sure why Scrutinizer is failing, it might be easier to just upload the clover.xml rather than running their CI which I guess may require its own config. I also don't have access to the Scrutinizer config but we should exclude |
I've updated the Scrutinizer config. |
I find the Symfony Finder exclude methods not very easy to use and unhelpful. For example: $finder = (new Finder())
->files()
->in(__DIR__)
->exclude(__DIR__.__DIRECTORY_SEPARATOR__.'tests')
; with:
will not exclude |
src/Console/Configuration.php
Outdated
if (false === is_array($finders)) { | ||
throw new InvalidArgumentException( | ||
sprintf( | ||
'Expected finders to be an array of callables, found "%s" instead.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can leave the of callables
part as it isn't asserted here.
ping @padraic |
Closes #84.