-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add patchers #67
Add patchers #67
Conversation
@theofidry Fire away and finish! :) |
@padraic were the patches that you applied enough? The e2e tests are still failing for me so maybe I got them wrong... |
@theofidry Hmm, it just needed those two patches. It could just be the makefile - if you check my PR, I made some changes in there to get everything passing: https://github.com/humbug/php-scoper/pull/65/files#diff-b67911656ef5d18c4ae36cb6741b7965L64 |
Will take a look |
Ok added some tests. I'm still a bit unhappy with the name as it's the same as the binary one which can be a bit confusing... Also regarding the error I could not find the source, however it looks like the regex doesn't anything (the code we are looking for doesn't exists anymore). I suppose this may be due to having different versions of PHP-Parser... Given how tightly coupled to it we are, we should fix it to a patch version and/or publish the I think publish the I think however that this should be fixed in another PR. |
PHP-Parser 3.0.6 was released about a week back. Checking it, I think they updated one line we are seeking to replace (removing backslash escapes and now using single backslashes): https://github.com/nikic/PHP-Parser/blob/0808939f81c1347a3c8a82a5925385a08074b0f1/lib/PhpParser/Lexer.php#L363 Updating the regular expression used ought to fix that as an issue. |
@Nyholm any suggestions for the config file name? |
Lets keep it simple: |
|
We could always return to the convention for include files: |
Fix the indentation of the doc to appear alligned when calling `make`.
fff1d6f
to
e5661ac
Compare
Attempt to replace #65. It's still not finished as:
Closes #63
@padraic if you're happy with the idea I'll try to finish that PR (unless you want to finish it ofc).