Whitelist functions as soon as they are used #269
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if you had the following code:
with
foo
being in the whitelist, the function would have not been whitelisted. The reasoning was that the recording of whitelisted elements was the same for functions and classes. For classes, it makes sense since the whitelisting will not work if the whitelisted class declaration is not found, however this is not the case for functions since the declaration dumped in thescoper-autoload.php
is sufficient.With this PR, the function
foo
above is now prefixed, which should allow cases like this one to work out of the box, either by whitelisting the global functions or by manually whitelisting it.