Fix the whitelisting of classes #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theofidry
force-pushed
the
bugfix/whitelist-classes
branch
from
ad75768 to
03fefae
Compare
- Add more checks - Fix the usage with whitelisted files
theofidry
force-pushed
the
bugfix/whitelist-classes
branch
from
03fefae to
5b7ce82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A change has been made in the whitelist behaviour in order to support the whitelisting of global classes: instead of blindly applying aliases with their
class_alias()statements in thescoper-autoload.php, the whitelisted classes found are recorded and thescoper-autoload.phpwill contain all theclass_alias()statements necessary. However the Scoper autoload dumper was not updated to reflect on that new API/cc @sebastianfeldmann & @kambo-1st I'll try to release that ASAP since it's likely to be a blocker for you guys