Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail when files are found in _specs #232

Merged
merged 14 commits into from
Jul 1, 2018
Merged

Fail when files are found in _specs #232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
6f4fd64
Fail when files are found in _specs
theofidry Jul 1, 2018
ce6d065
Add files in _specs to Git
theofidry Jul 1, 2018
512ad71
Fix config
theofidry Jul 1, 2018
a38fa9a
Fail fast
theofidry Jul 1, 2018
fe4d4f9
try something else
theofidry Jul 1, 2018
fe3390f
another try
theofidry Jul 1, 2018
292f087
Rmove extra files
theofidry Jul 1, 2018
1bd1639
try something else
theofidry Jul 1, 2018
bfb8cbf
try x
theofidry Jul 1, 2018
58afa20
add file
theofidry Jul 1, 2018
73d9790
something else
theofidry Jul 1, 2018
265d312
Remove extra file
theofidry Jul 1, 2018
aada904
Add test to PhpScoperTest & add contribution doc
theofidry Jul 1, 2018
188882d
revert contrib doc
theofidry Jul 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 _specs/.gitignore → _specs/.gitkeep
View file
Open in desktop
File renamed without changes.
19 changes: 13 additions & 6 deletions tests/Scoper/PhpScoperTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -511,15 +511,22 @@ public function test_can_scope_valid_files(string $spec, string $contents, strin
);
}

/**
* This test is to ensure no file is left in _specs for the CI. It is fine otherwise for this test to fail locally
* when developing something.
*/
public function test_it_uses_the_right_specs_directory()
{
$files = (new Finder())->files()->in(self::SECONDARY_SPECS_PATH);

$this->assertCount(0, $files);
}

public function provideValidFiles()
{
if (file_exists(self::SECONDARY_SPECS_PATH)) {
$files = (new Finder())->files()->in(self::SECONDARY_SPECS_PATH);
$files = (new Finder())->files()->in(self::SECONDARY_SPECS_PATH);

if (0 === count($files)) {
$files = (new Finder())->files()->in(self::SPECS_PATH);
}
} else {
if (0 === count($files)) {
$files = (new Finder())->files()->in(self::SPECS_PATH);
}

Expand Down