Fix the scoping of JSON files #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theofidry
force-pushed
the
bugfix/fix-scoping-of-json-files
branch
4 times, most recently
from
8226ee5 to
17e3a33
Compare
The JSON files should be decode with `assoc` set to true. Otherwise encoding it again may change the
schema as if `assoc` is set to false, both `[]` and `{}` will be decoded as an empty array so
encoding it again may change an empty object into an empty array which may screw up a JSON schema
validation.
theofidry
force-pushed
the
bugfix/fix-scoping-of-json-files
branch
from
17e3a33 to
ba9ca20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JSON files should be decode with
assocset to true. Otherwise encoding it again may change the schema as ifassocis set to false, both[]and{}will be decoded as an empty array soencoding it again may change an empty object into an empty array which may screw up a JSON schema validation.