Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Php parser 4 #203

Merged
merged 7 commits into from
May 28, 2018
Merged

Upgrade to Php parser 4 #203

merged 7 commits into from
May 28, 2018

Conversation

TomasVotruba
Copy link
Contributor

This PR waits on BetterReflection to be tagged. Ready otherwise

@TomasVotruba
Copy link
Contributor Author

Ref Roave/BetterReflection#410

@TomasVotruba
Copy link
Contributor Author

It's ready

https://github.com/Roave/BetterReflection/releases/tag/3.0.0

@TomasVotruba TomasVotruba changed the title [WAITS] Upgrade to Php parser 4 Upgrade to Php parser 4 May 28, 2018
@TomasVotruba
Copy link
Contributor Author

Any ETA?

@TomasVotruba TomasVotruba mentioned this pull request May 28, 2018
Merged
7 tasks
@theofidry
Copy link
Member

Sorry missed your comment from yesterday. One rebase and I think we're ready to go

@theofidry theofidry merged commit 91fae9c into humbug:master May 28, 2018
@theofidry
Copy link
Member

Thanks you @TomasVotruba!

@TomasVotruba TomasVotruba deleted the php-parser-4 branch May 28, 2018 18:20
@TomasVotruba
Copy link
Contributor Author

@theofidry Happy to help ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TomasVotruba @theofidry