Check requirements when running from a PHAR #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theofidry
force-pushed
the
feature/requirements-check
branch
from
d0e6d8c to
441e039
Compare
theofidry
force-pushed
the
feature/requirements-check
branch
from
3ac36e0 to
44bd87c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An issue one may come across when running a PHAR, as opposed to when you install a tool via Composer, is that no check whatsoever is run.
By leveraging symfony/requirements-checker, a check is now run when running the PHAR. The check is run before anything. The output is the following when checks are passing in very verbose mode (
-vvor-vvv):If the very verbose mode is not given, nothing is displayed unless an error occurs. If the checks don't pass, regardless of the verbosity specified, the errors will be printed: