Make traverser return a new instance for each file #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 30, 2017 09:19
As the traverser is now stateful, even though it won't break things as the code is robust enough right now, it severely impacts performances. For example, the collection of namespace was kept which led to a lot of namespaces at some point forcing the NamespaceCollection to go through the node parents to find the proper namespace, even though only one namespace was found in the file.
theofidry
force-pushed
the
bugfix/reset-traverser
branch
from
31b4167 to
c5fb376
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the traverser is now statefull, even though it won't break things
as the code is robust enough right now, it severely impacts performances.
For example, the collection of namespace was kept which led to a lot of
namespaces at some point forcing the NamespaceCollection to go through
the node parents to find the proper namespace, even though only one
namespace was found in the file.