-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix function with multiple namespaces #1061
Conversation
Thank you @VincentLanglet, I'll try to check the CI ASAP to fix it to get this merged |
Should I fix the test on this PR @theofidry ? It seems to mainly be CS issues |
@VincentLanglet the CS yes (I think it's related), but the test failures looks unrelated so in a different MR. Sorry I'm a bit overwhelmed IRL between visists and moving and stuff |
|
7f17c41
to
cf83e25
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM otherwise
Hi @theofidry, I discovered a bug with the php-scoper.
Before the fix, I get
which is crashing.