Simplify a few tests using named parameters (#769)

humbug · Nov 13, 2022 · 8ba7d27 · 8ba7d27
1 parent 3dc5aa3
commit 8ba7d27
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 18 deletions.
diff --git a/tests/PhpScoperAssertions.php b/tests/PhpScoperAssertions.php
@@ -30,7 +30,6 @@ public static function assertListEqualsCanonicalizing(
     ): void {
         Assert::assertIsArray($actual);
 
-        // TODO: contribute this to PHPUnit
         // TODO: use assertArrayIsList() assertion once available
         // https://github.com/sebastianbergmann/phpunit/commit/71f507496aa1a483b32d9257d6f3477e6e5c091d
         Assert::assertTrue(

diff --git a/tests/Scoper/Composer/InstalledPackagesScoperTest.php b/tests/Scoper/Composer/InstalledPackagesScoperTest.php
@@ -381,12 +381,8 @@ public static function provideInstalledPackagesFiles(): iterable
         yield 'fideloper/proxy excerpt with excluded provider' => [
             new EnrichedReflector(
                 Reflector::createEmpty(),
-                // TODO: named params
                 SymbolsConfiguration::create(
-                    false,
-                    false,
-                    false,
-                    NamespaceRegistry::create(['Fideloper']),
+                    excludedNamespaces: NamespaceRegistry::create(['Fideloper']),
                 ),
             ),
             <<<'JSON'

diff --git a/tests/Symbol/EnrichedReflectorFactoryTest.php b/tests/Symbol/EnrichedReflectorFactoryTest.php
@@ -26,19 +26,10 @@ final class EnrichedReflectorFactoryTest extends TestCase
 {
     public function test_it_can_create_an_enriched_reflector(): void
     {
-        // TODO: named param could help here
         $symbolsConfiguration = SymbolsConfiguration::create(
-            false,
-            false,
-            false,
-            null,
-            null,
-            null,
-            null,
-            null,
-            SymbolRegistry::create(['Acme\Foo']),
-            SymbolRegistry::create(['Acme\main']),
-            SymbolRegistry::createForConstants(['Acme\BAR']),
+            excludedClasses: SymbolRegistry::create(['Acme\Foo']),
+            excludedFunctions: SymbolRegistry::create(['Acme\main']),
+            excludedConstants: SymbolRegistry::createForConstants(['Acme\BAR']),
         );
 
         $factory = new EnrichedReflectorFactory(Reflector::createEmpty());