Remove useless parameter & Refactor node cloning (#134)

humbug · Dec 26, 2017 · 6be5c00 · 6be5c00
1 parent 74281d9
commit 6be5c00
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 62 deletions.
diff --git a/src/NodeVisitor/NamespaceStmtPrefixer.php b/src/NodeVisitor/NamespaceStmtPrefixer.php
@@ -38,18 +38,15 @@ final class NamespaceStmtPrefixer extends NodeVisitorAbstract
 {
     private $prefix;
     private $namespaceStatements;
-    private $whitelist;
 
     /**
      * @param string                  $prefix
      * @param NamespaceStmtCollection $namespaceStatements
-     * @param string[]                $whitelist
      */
-    public function __construct(string $prefix, NamespaceStmtCollection $namespaceStatements, array $whitelist)
+    public function __construct(string $prefix, NamespaceStmtCollection $namespaceStatements)
     {
         $this->prefix = $prefix;
         $this->namespaceStatements = $namespaceStatements;
-        $this->whitelist = $whitelist;
     }
 
     /**

diff --git a/src/Scoper/TraverserFactory.php b/src/Scoper/TraverserFactory.php
@@ -56,7 +56,7 @@ public function create(string $prefix, array $whitelist, callable $globalWhiteli
 
         $traverser->addVisitor(new NodeVisitor\AppendParentNode());
 
-        $traverser->addVisitor(new NodeVisitor\NamespaceStmtPrefixer($prefix, $namespaceStatements, $whitelist));
+        $traverser->addVisitor(new NodeVisitor\NamespaceStmtPrefixer($prefix, $namespaceStatements));
 
         $traverser->addVisitor(new NodeVisitor\UseStmt\UseStmtCollector($namespaceStatements, $useStatements));
         $traverser->addVisitor(new NodeVisitor\UseStmt\UseStmtPrefixer($prefix, $whitelist, $globalWhitelister));

diff --git a/src/functions.php b/src/functions.php
@@ -33,7 +33,6 @@
 use PhpParser\ParserFactory;
 use Symfony\Component\Console\Application as SymfonyApplication;
 use Symfony\Component\Filesystem\Filesystem;
-use UnexpectedValueException;
 
 /**
  * @private
@@ -185,60 +184,5 @@ function deep_clone($node)
         return $node;
     }
 
-    if ($node instanceof Node\Stmt\Namespace_) {
-        return new Node\Stmt\Namespace_(
-            deep_clone($node->name)
-        );
-    }
-
-    if ($node instanceof Node\Name\Relative) {
-        return new Node\Name\Relative(
-            deep_clone($node->toString())
-        );
-    }
-
-    if ($node instanceof Node\Name\FullyQualified) {
-        return new Node\Name\FullyQualified(
-            deep_clone($node->toString())
-        );
-    }
-
-    if ($node instanceof Node\Name) {
-        return new Node\Name(
-            deep_clone($node->toString())
-        );
-    }
-
-    if ($node instanceof Node\Stmt\Use_) {
-        return new Node\Stmt\Use_(
-            deep_clone($node->uses),
-            $node->type
-        );
-    }
-
-    if ($node instanceof Node\Stmt\UseUse) {
-        return new Node\Stmt\UseUse(
-            deep_clone($node->name),
-            $node->alias,
-            $node->type
-        );
-    }
-
-    if ($node instanceof Node\Stmt\Class_) {
-        return new Node\Stmt\Class_(
-            deep_clone($node->name),
-            [
-                'flags' => deep_clone($node->flags),
-                'extends' => deep_clone($node->extends),
-                'implements' => deep_clone($node->implements),
-            ]
-        );
-    }
-
-    throw new UnexpectedValueException(
-        sprintf(
-            'Cannot clone element "%s".',
-            get_class($node)
-        )
-    );
+    return unserialize(serialize($node));
 }