Added support for PHP 5.3.3 #8
Conversation
|
👎 |
|
I really don't want to see new libraries supporting EOL php. :( |
|
@GrahamCampbell That depends largely on the target audience. For very low-level libraries with a large target audience, support for 5.3 is unfortunately still mandatory. For high-level libs or frameworks, that's a different story, of course.. |
|
@GrahamCampbell not supporting PHP 5.3 in this library means that any tools which wants to keep support for 5.3 would have to implement phar-updating themselves rather than using this secure implementation. |
|
Or it just forces them off php 5.3... |
| @@ -5,6 +5,7 @@ php: | |||
| - 5.6 | |||
| - 5.5 | |||
| - 5.4 | |||
| - 5.3.3 | |||
There was a problem hiding this comment.
you should test on 5.3 rather than 5.3.3. The 5.3.3 image on Travis does nont have OpenSSL
There was a problem hiding this comment.
The point of this was to prove that it works on php 5.3.3 and not just a much later version of 5.3 though isn't it?
There was a problem hiding this comment.
well, then it should be tested on both. Hopefully people still using 5.3 are at least on a recent 5.3 version
|
@padraic tests checking that phars signed with openssl are updated should be skipped if the system running the tests does not have Openssl |
|
@GrahamCampbell You can do that if you change the min version for large and established projects (ZF, Symfony, Typo3, ..). New and yet unused libraries won't force anyone. |
|
@webmozart Symfony is moving forward though. 2.7 needs more than just php 5.3.3 now, and 3.0 will need 5.5.9+. |
|
@GrahamCampbell sure. but phar-updater does not have the same power. If it requires 5.4+, projects allowing 5.3 today will just avoid switching to phar-updater |
|
I added 5.3 to travis.yml and marked the tests as skipped now that fail if openssl is not installed. Travis is green now. |
| if (!extension_loaded('openssl')) { | ||
| $this->markTestSkipped('This test requires the openssl extension to run.'); | ||
|
|
||
| return; |
There was a problem hiding this comment.
no need to return here (markTestSkipped actually throw an exception to stop the test)
There was a problem hiding this comment.
really? :) I never cared to look inside, good to know
…is missing (i.e. 5.3.3 on Travis)
|
I'd prefer to see folk adopt secure updates, and the reality is that phar-updater is genuinely too small with the sole 5.4 feature used being short array syntax. 5.4 adoption is better driven by larger units of functionality. I already have Humbug and Mockery at 5.4, so compromise is fine by me on this significantly smaller focused package. |
|
I'll tag a new release in a few hours @webmozart. |
|
Thanks a lot, much appreciated :) |
|
And tagged. |
|
Awesome! 👏 |
This branch replaces the short by the long array notation to add support for PHP 5.3.3.