Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: switch to new method of releases #250

Closed
wants to merge 1 commit into from
Closed

fix: switch to new method of releases #250

wants to merge 1 commit into from

Conversation

Lash-L
Copy link
Collaborator

@Lash-L Lash-L commented Nov 20, 2024

This one works by pushing the release out based on github releases. When you make a release there (it will auto draft releases), it pushes it. Doesn't do the fancy changelog and version updating, but I'm okay with that for now if I can stop hitting my head against the wall trying to get semantic release to work

@humbertogontijo
Copy link
Owner

Approved. About the semantic release, I think it tries to work for every language and every exception. That makes it really complex.
But I will agree with any solution you find best.
You can also work on a fork to make everything faster(not depending on my approvals while testing). I guess your fork would work like this repo since you are also a pypi owner

@Lash-L
Copy link
Collaborator Author

Lash-L commented Nov 20, 2024

Okay now that I have ownership maybe that will change my approach a bit. I will try testing a bit more on a separate branch.

Although - I don't see the settings page or anything else that seems to imply that I have ownership role - perhaps it takes a while?

@Lash-L
Copy link
Collaborator Author

Lash-L commented Nov 20, 2024

Gonna close this in favor of the fixes on the other

@Lash-L Lash-L closed this Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants