[SDK][Agreement] Harmonize Interfaces of Agreement Measures #975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/sdk/python/human-protocol-sdk/human_protocol_sdk/agreement/__init__.py # packages/sdk/python/human-protocol-sdk/human_protocol_sdk/agreement/bootstrap.py # packages/sdk/python/human-protocol-sdk/human_protocol_sdk/agreement/measures.py # packages/sdk/python/human-protocol-sdk/human_protocol_sdk/agreement/utils.py # packages/sdk/python/human-protocol-sdk/test/human_protocol_sdk/agreement/test_bootstrap.py # packages/sdk/python/human-protocol-sdk/test/human_protocol_sdk/agreement/test_measures.py # packages/sdk/python/human-protocol-sdk/test/human_protocol_sdk/agreement/test_utils.py
# Conflicts: # packages/sdk/python/human-protocol-sdk/human_protocol_sdk/agreement/__init__.py # packages/sdk/python/human-protocol-sdk/human_protocol_sdk/agreement/measures.py # packages/sdk/python/human-protocol-sdk/human_protocol_sdk/agreement/utils.py # packages/sdk/python/human-protocol-sdk/test/human_protocol_sdk/agreement/test_bootstrap.py # packages/sdk/python/human-protocol-sdk/test/human_protocol_sdk/agreement/test_measures.py # packages/sdk/python/human-protocol-sdk/test/human_protocol_sdk/agreement/test_utils.py
simulacrum6
added
SDK
IRA Package
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Ignored Deployments
|
flopez7
approved these changes
Oct 4, 2023
portuu3
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aligns the data format required by all measures under the agreement package.
Previously, different agreement measures required annotations in different formats as input. This made it hard to use them, as the users needed to know, which format their data had to be transformed into. It also made bootstrapping more tricky, as sampling from some data formats is not straightforward.
Summary of changes
How test the changes
pytest <PATH_TO_PYTHON_SDK/test/human_protocol_sdk/agreementRelated issues
Closes #944.
Operational checklist