[Job Launcher] Added job id relation to the payment #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
portuu3
approved these changes
Aug 28, 2023
eugenvoronov
added a commit
that referenced
this pull request
Aug 29, 2023
* Added cancel job functionality * Updated job controller * Updated type to patch and validation params approach * Updated job cancelation logic * Added job cancel functionality * Added enums webhook * Resolved comments * [Job Launcher] Added job id relation to the payment (#835) * Updated payment entity and migration * Updated job service * Updated unit tests * Updated unit tests
eugenvoronov
added a commit
that referenced
this pull request
Aug 29, 2023
* Added cancel job functionality * Updated job controller * Updated type to patch and validation params approach * Updated job cancelation logic * Added job cancel functionality * Added enums webhook * Resolved comments * [Job Launcher] Added job id relation to the payment (#835) * Updated payment entity and migration * Updated job service * Updated unit tests * Updated unit tests * [Job Launcher] Added job cancelation cron endpoint for vercel (#838) * Added cancel crone endpoint * Updated vercel.json * Updated controller * Updated storage clietn params order * Resolved conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For ensure job cancelation correct, withdrawal payment related with the particular job id need to be failed, for this purpose job id field was added to payment entity.
Summary of changes
The assumption (for simplicity) that one job has one payment works. The solution implements a one-to-one relationship.
Related issues
[Job Launcher] Add job id property to payment entity#834