Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update python and node sdk for release #513

Merged
merged 2 commits into from
May 29, 2023
Merged

Conversation

leric7
Copy link
Collaborator

@leric7 leric7 commented May 29, 2023

Description

Adjust Python and Node.js SDK for a release.

Summary of changes

  • Added a new function getRecordingOracle to Node.js SDK.
  • Updated core package to have typescript build
  • Updated relevant core package pre build for vercel deployment & github actions.
  • Updated python SDK to include artifacts directory.

How test the changes

Related issues

Keywords for linking issues

Operational checklist

  • All new functionality is covered by tests
  • Any related documentation has been changed or added

@vercel
Copy link

vercel bot commented May 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
escrow-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 29, 2023 1:54pm
faucet-server ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 29, 2023 1:54pm
fortune-exchange-oracle ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 29, 2023 1:54pm
fortune-exchange-oracle-server ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 29, 2023 1:54pm
fortune-job-launcher-client ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 29, 2023 1:54pm
fortune-job-launcher-server ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 29, 2023 1:54pm
fortune-recording-oracle ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 29, 2023 1:54pm
fortune-reputation-oracle ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 29, 2023 1:54pm

@vercel vercel bot temporarily deployed to Preview – fortune-job-launcher-server May 29, 2023 13:28 Inactive
@vercel vercel bot temporarily deployed to Preview – fortune-recording-oracle May 29, 2023 13:28 Inactive
@vercel vercel bot temporarily deployed to Preview – fortune-job-launcher-client May 29, 2023 13:29 Inactive
@vercel vercel bot temporarily deployed to Preview – fortune-reputation-oracle May 29, 2023 13:30 Inactive
@vercel vercel bot temporarily deployed to Preview – fortune-exchange-oracle May 29, 2023 13:30 Inactive
@vercel vercel bot temporarily deployed to Preview – fortune-exchange-oracle-server May 29, 2023 13:32 Inactive
Copy link
Contributor

@flopez7 flopez7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you add a new method for typescript, you have to create it also for python, both SDK have to be similar. Also add the tests for those new methods

@leric7 leric7 requested a review from flopez7 May 29, 2023 13:49
@vercel vercel bot temporarily deployed to Preview – fortune-recording-oracle May 29, 2023 13:50 Inactive
@vercel vercel bot temporarily deployed to Preview – fortune-reputation-oracle May 29, 2023 13:51 Inactive
@vercel vercel bot temporarily deployed to Preview – fortune-job-launcher-server May 29, 2023 13:52 Inactive
@vercel vercel bot temporarily deployed to Preview – fortune-exchange-oracle May 29, 2023 13:52 Inactive
@vercel vercel bot temporarily deployed to Preview – fortune-exchange-oracle-server May 29, 2023 13:53 Inactive
@vercel vercel bot temporarily deployed to Preview – fortune-job-launcher-client May 29, 2023 13:53 Inactive
flopez7
flopez7 previously approved these changes May 29, 2023
@leric7 leric7 changed the base branch from main to develop May 29, 2023 14:19
@leric7 leric7 dismissed flopez7’s stale review May 29, 2023 14:19

The base branch was changed.

@leric7 leric7 merged commit fd2557b into develop May 29, 2023
leric7 added a commit that referenced this pull request May 29, 2023
* update python and node sdk for release

* add reputation oracle function and test
leric7 added a commit that referenced this pull request May 29, 2023
@leric7 leric7 deleted the feat/sdk-release branch June 23, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants