Fix: Staking/RewardPool contracts #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Ignored Deployments
|
|
@portuu3 , added test cases to cover these changes. I think we need to setup coverage test in the near future. |
vercel
bot
temporarily deployed
to
Preview – fortune-exchange-oracle-server
vercel
bot
temporarily deployed
to
Preview – fortune-exchange-oracle-server
vercel
bot
temporarily deployed
to
Preview – fortune-exchange-oracle-server
portuu3
approved these changes
Apr 24, 2023
m00n620
pushed a commit
that referenced
this pull request
May 4, 2023
* fix core staking / reward pool contracts * add test cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed Staking/RewardPool contracts.
Summary of changes
Some of the validations were wrong/missing.
How test the changes
Related issues
Keywords for linking issues
Closes #389
Closes #390
Closes #391
Closes #394
Operational checklist