-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Reputation Oracle] Improved webhooks #2658
Open
eugenvoronov
wants to merge
5
commits into
develop
Choose a base branch
from
feature/rep-oracle/refact-process-paid-webhooks
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Reputation Oracle] Improved webhooks #2658
eugenvoronov
wants to merge
5
commits into
develop
from
feature/rep-oracle/refact-process-paid-webhooks
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
vercel
bot
temporarily deployed
to
Preview – human-dashboard-frontend
October 18, 2024 08:00
Inactive
Dzeranov
requested changes
Oct 21, 2024
packages/apps/reputation-oracle/server/src/modules/webhook/webhook.dto.ts
Outdated
Show resolved
Hide resolved
packages/apps/reputation-oracle/server/src/modules/webhook/webhook.controller.ts
Outdated
Show resolved
Hide resolved
vercel
bot
temporarily deployed
to
Preview – human-dashboard-frontend
October 23, 2024 12:17
Inactive
vercel
bot
temporarily deployed
to
Preview – human-dashboard-frontend
October 23, 2024 12:18
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reworked the
processPaidWebhooks
cron job to improve the handling of webhook notifications and prevent unnecessary retries of completed escrows. The goal is to implement a webhook queue that effectively tracks which notifications have failed to be sent.Summary of changes
WebhookIncomingEntity
toWebhookEntity
and introduced a type enum field to differentiate between incoming and outgoing webhooks. Added fields forfailedReason
andcallbakUrl
to enhance error tracking.process-outgoing-webhook
value.WebhookEntity
entries with type:in
andpending
status. This module checks escrow status and processes escrows accordingly.WebhookEntity
instances with type:out
andpending
status are generated for sending notifications.WebhookEntity
entries with type:in
is updated tocompleted
once processing is successful.WebhookEntity
entries with type:out
. It attempts to send notifications usingwebhookService.sendWebhook()
, handling retries and failures appropriately.How test the changes
yarn test
Related issues
[Reputation Oracle] Refactor processPaidWebhooks method #2638