[CORE][SDK] Remove allocation from Staking contract #2651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
vercel
bot
temporarily deployed
to
Preview – human-dashboard-frontend
vercel
bot
temporarily deployed
to
Preview – human-dashboard-frontend
vercel
bot
temporarily deployed
to
Preview – human-dashboard-frontend
vercel
bot
temporarily deployed
to
Preview – human-dashboard-frontend
vercel
bot
temporarily deployed
to
Preview – human-dashboard-frontend
vercel
bot
temporarily deployed
to
Preview – human-dashboard-frontend
flopez7
force-pushed
the
feat/contracts/remove-allocation
branch
from
37dcf08
to
2adb311
Compare
portuu3
reviewed
Oct 31, 2024
| @@ -69,6 +69,7 @@ export class PayoutService { | |||
| results.amounts, | |||
| results.url, | |||
| results.hash, | |||
| true, | |||
There was a problem hiding this comment.
I think this should not be hardcoded to true.
portuu3
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove allocation from Staking contract and update SDK
Summary of changes
Removed allocation and all it's related changes from staking.
Remove RewardPool contract
Updated Python and Typescript SDK
Related issues
#2364