Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK] Fix KvstoreUtils.get for compatibility with old versions #2434

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

portuu3
Copy link
Collaborator

@portuu3 portuu3 commented Aug 23, 2024

Description

Fix KvstoreUtils.get for compatibility with old versions.

Summary of changes

Return an empty string instead of an exception in case the key is not found

How test the changes

yarn test

@portuu3 portuu3 self-assigned this Aug 23, 2024
Copy link

vercel bot commented Aug 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
escrow-dashboard ⬜️ Ignored (Inspect) Aug 23, 2024 9:24am
faucet-server ⬜️ Ignored (Inspect) Visit Preview Aug 23, 2024 9:24am

Dzeranov
Dzeranov previously approved these changes Aug 23, 2024
@portuu3 portuu3 requested a review from Dzeranov August 23, 2024 08:58
@portuu3 portuu3 merged commit 1c527db into develop Aug 23, 2024
20 checks passed
@portuu3 portuu3 deleted the fix/kvstoreutils branch August 23, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants