[Reputation Oracle] Config service #1810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Ignored Deployments
|
portuu3
requested changes
Apr 4, 2024
packages/apps/reputation-oracle/server/src/common/config/sendgrid-config.service.ts
Outdated
Show resolved
Hide resolved
portuu3
approved these changes
Apr 5, 2024
portuu3
pushed a commit
that referenced
this pull request
Apr 5, 2024
* Improve config service in reputation oracle * Use disabled as default value for SENDGRID_API_KEY * Create new KYC entry when synaps apiKey disabled * Fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve ConfigService and the way Reputation Oracle works with env variables
Summary of changes
Instead of using default ConfigService, use specific config with custom getters
How test the changes
yarn testRelated issues
#1754