use trusted modifier in complete function (#459)

humanprotocol · May 10, 2023 · ed5b9f4 · ed5b9f4 · vercel · May 10, 2023
1 parent 73cbee6
commit ed5b9f4
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/packages/core/contracts/Escrow.sol b/packages/core/contracts/Escrow.sol
@@ -158,11 +158,7 @@ contract Escrow is IEscrow, ReentrancyGuard {
         return true;
     }
 
-    function complete() external override notExpired {
-        require(
-            areTrustedHandlers[msg.sender],
-            'Address calling is not trusted'
-        );
+    function complete() external override notExpired trusted {
         require(status == EscrowStatuses.Paid, 'Escrow not in Paid state');
         status = EscrowStatuses.Complete;
         emit Completed();

diff --git a/packages/core/test/Escrow.ts b/packages/core/test/Escrow.ts
@@ -628,7 +628,7 @@ describe('Escrow', function () {
       it('Should revert with the right error if address calling is not trusted', async function () {
         await expect(
           escrow.connect(externalAddress).complete()
-        ).to.be.revertedWith('Address calling is not trusted');
+        ).to.be.revertedWith('Address calling not trusted');
       });
 
       it('Should revert with the right error if escrow not in Paid status state', async function () {