Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix issue #590 #618

Merged
merged 3 commits into from
Aug 22, 2024
Merged

fix issue #590 #618

merged 3 commits into from
Aug 22, 2024

Conversation

jongyaoY
Copy link

Solved [#590] by exposing IdVisitor of collision geometries, but it requires eigenpy >=3.7.0

@jongyaoY
fix issue humanoid-path-planner#590
931c661 
expose IdVisitor of all other collision geometries
nim65s
nim65s requested changes Aug 21, 2024
View reviewed changes
Copy link
Member

@nim65s nim65s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This require a new version of eigenpy, v3.8.0, so this is a breaking change.
It will break at least the CI on systems were eigenpy v3.8.0 is not yet available.

Could you guard those changes with #if EIGENPY_VERSION_AT_LEAST(3, 8, 0), to fix this ?

@jongyaoY jongyaoY requested a review from nim65s August 21, 2024 18:04
nim65s
nim65s approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@nim65s nim65s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@jcarpent jcarpent merged commit 7e3f33b into humanoid-path-planner:devel Aug 22, 2024
32 checks passed
@jcarpent jcarpent mentioned this pull request Aug 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nim65s nim65s nim65s approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jongyaoY @nim65s @jcarpent