Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filter for local provider name #48

Merged
merged 3 commits into from
Sep 14, 2021
Merged

Conversation

soderlind
Copy link
Contributor

@soderlind soderlind commented Sep 9, 2021

Add filter amf/local_provider/name, which allows you to change the local provider name.

fixes #47

@roborourke roborourke changed the title Add filter for local provider name, fixes #47 Add filter for local provider name Sep 13, 2021
Copy link
Contributor

@roborourke roborourke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically not a bug fix so a patch version change doesn't seem appropriate even though it is backwards compatible. I'm not really concerned about that though.

The intended method to do this is to extend the Local Provider class and swap it / decorate it using the amf/provider filter. I think that's why we left the filter out in the end, to keep things more object oriented - it's documented as using a "Decorating Provider" in the readme at any rate.

I think this filter should at least be documented under this section https://github.com/humanmade/asset-manager-framework#local-media

@roborourke roborourke merged commit 380c215 into humanmade:master Sep 14, 2021
@roborourke
Copy link
Contributor

Thanks @soderlind. Can I ask what capacity you're using this plugin in? Always keen to understand how folks are using this library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter the local provider name
2 participants