Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add route53 module #3

Merged
merged 11 commits into from
Feb 8, 2024
Merged

feat: add route53 module #3

merged 11 commits into from
Feb 8, 2024

Conversation

mateuszjenek
Copy link
Contributor

No description provided.

@mateuszjenek mateuszjenek requested a review from a team as a code owner December 19, 2023 20:48
@chrishumanitec
Copy link
Contributor

General question: Why not just use our built in route53 driver in this case?

type = string
}

variable "access_key" {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will not work with the upcomming temporary credentials.
AWS includes a Session Token for temporary credentails

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None of the existing resources support temporary credentials yet, so I wouldn’t block this PR for this.

Happy to update all of them once the design is finalized.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are being added now e.g. for the route53 driver.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I meant none of the existing pack resources support temporary credentials yet and I would generally track supporting this as a follow up.

humanitec-resource-defs/route53/main.tf Outdated Show resolved Hide resolved
modules/route53/variables.tf Outdated Show resolved Hide resolved
modules/route53/main.tf Outdated Show resolved Hide resolved
@johanneswuerbach johanneswuerbach marked this pull request as draft January 2, 2024 09:42
@johanneswuerbach
Copy link
Contributor

Moving back into draft as previously discussed.

@mateuszjenek mateuszjenek marked this pull request as ready for review February 7, 2024 13:26
@mateuszjenek mateuszjenek merged commit 41e4f12 into humanitec-architecture:main Feb 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants