-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add route53 module #3
Conversation
General question: Why not just use our built in route53 driver in this case? |
type = string | ||
} | ||
|
||
variable "access_key" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will not work with the upcomming temporary credentials.
AWS includes a Session Token for temporary credentails
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
None of the existing resources support temporary credentials yet, so I wouldn’t block this PR for this.
Happy to update all of them once the design is finalized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are being added now e.g. for the route53 driver.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I meant none of the existing pack resources support temporary credentials yet and I would generally track supporting this as a follow up.
Moving back into draft as previously discussed. |
No description provided.