Fix race condition of dataPromise and responseReceived(fix #16) #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) This is the cause of "window size reached" bug. If responseReceived thread is suspended when dataPromise.succeed call, and another thread which waked up by dataPromisss.succeed call reciveData again, that second call create dataPromise promise. Then resume responseRecived thread clear dataPromise property without calling succeed, which cause forever waiting. In this fix, dataPromise and cachedRecivedData is isolated by actor and access only from the same actor context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the cause of "window size reached" bug.
If responseReceived thread is suspended when dataPromise.succeed call, and another thread which waked up by dataPromisss.succeed call reciveData again, that second call create dataPromise promise. Then resume responseRecived thread clear dataPromise property without calling succeed, which cause forever waiting.
In this fix, dataPromise and cachedRecivedData is isolated by actor and access only from the same actor context.