fix: Modify validation to check Analysis args passed through RO spec (a…

…rgoproj#1215) * fix: Modify validation to check Analysis args passed through RO spec Signed-off-by: khhirani <[email protected]> Signed-off-by: caoyang001 <[email protected]>
huikang · Sep 16, 2021 · 7ca2446 · 7ca2446
1 parent c26bd77
commit 7ca2446
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/pkg/apis/rollouts/validation/validation_references.go b/pkg/apis/rollouts/validation/validation_references.go
@@ -3,6 +3,9 @@ package validation
 import (
 	"fmt"
 
+	appsv1 "k8s.io/api/apps/v1"
+	v1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+
 	analysisutil "github.com/argoproj/argo-rollouts/utils/analysis"
 	"github.com/argoproj/argo-rollouts/utils/conditions"
 	istioutil "github.com/argoproj/argo-rollouts/utils/istio"

diff --git a/rollout/controller.go b/rollout/controller.go
@@ -667,6 +667,7 @@ func (c *rolloutContext) getReferencedRolloutAnalyses() (*[]validation.AnalysisT
 		for i, step := range canary.Steps {
 			if step.Analysis != nil {
 				templates, err := c.getReferencedAnalysisTemplates(c.rollout, step.Analysis, validation.InlineAnalysis, i)
+				templates.Args = step.Analysis.Args
 				if err != nil {
 					return nil, err
 				}