GefSetting: Validate valid bool settings

hugsy · Aug 26, 2023 · e7a4b1f · e7a4b1f
1 parent 27ed67a
commit e7a4b1f
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/gef.py b/gef.py
@@ -9809,7 +9809,12 @@ def set_setting(self, argv: Tuple[str, Any]) -> None:
         _type = gef.config.raw_entry(key).type
         try:
             if _type == bool:
-                _newval = True if new_value.upper() in ("TRUE", "T", "1") else False
+                if new_value.upper() in ("TRUE", "T", "1"):
+                    _newval = True
+                elif new_value.upper() in ("FALSE", "F", "0"):
+                    _newval = False
+                else:
+                    raise ValueError(f"cannot parse '{new_value}' as bool")
             else:
                 _newval = new_value
         except Exception as e: