Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setuptools_scm generating version 0.0.0 #33

Merged
merged 8 commits into from
Apr 29, 2020
Merged

Conversation

hugovk
Copy link
Owner

@hugovk hugovk commented Apr 29, 2020

#31 resulted in https://test.pypi.org/project/tinytext/0.0.0/

to use setup.py as you write, you either need the latest setuptools and the latest setuptools_scm pre-installed or as setup_requires in setup.py/cfg,

setup.py invocations will NOT install build requirements from pyproject.toml

if you have a modern pip installed, i believe a pip wheel . should produce the desired results

pypa/setuptools-scm#386 (comment)

@hugovk hugovk added bug Something isn't working testing Unit tests, linting, CI, etc. changelog: skip Exclude PR from release draft labels Apr 29, 2020
@codecov
Copy link

codecov bot commented Apr 29, 2020

Codecov Report

Merging #33 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #33   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           13        13           
=========================================
  Hits            13        13           
Flag Coverage Δ
#GHA_Ubuntu1604 100.00% <ø> (ø)
#GHA_Ubuntu1804 100.00% <ø> (ø)
#GHA_macOS 100.00% <ø> (ø)
#TravisCI 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68fbcba...103b83e. Read the comment docs.

@hugovk hugovk merged commit be890aa into master Apr 29, 2020
@hugovk hugovk deleted the fix-setuptools-scm branch April 29, 2020 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working changelog: skip Exclude PR from release draft testing Unit tests, linting, CI, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant