Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extracurricular activities url #770

Merged
merged 2 commits into from
Jul 3, 2023
Merged

Add extracurricular activities url #770

merged 2 commits into from
Jul 3, 2023

Conversation

BernatBC
Copy link
Member

@BernatBC BernatBC commented Jul 3, 2023

Description

Added the possibility to have an url for each extracurricular activity inside education section.

ATTENTION: IT WILL BREAK EXTRACURRICULAR ACTIVITIES SECTION

old format:

degrees:
- name: Example degree
  icon: fa-graduation-cap
  timeframe: September 2020 - Present
  institution:
    name: Example Institution
    url: "https://www.example.com"

  extracurricularActivities:
  - Example extracurricular activity no url
  - Example extracurricular activity no url

new format:

degrees:
- name: Example degree
  icon: fa-graduation-cap
  timeframe: September 2020 - Present
  institution:
    name: Example Institution
    url: "https://www.example.com"

  extracurricularActivities:
  - name: Example extracurricular activity with url
    url: "https://www.example.com"
  - name: Example extracurricular activity no url

Test Evidence

using the new format, the result is the following:
educationSection

I haven't added this changes to hugo-toha/guides as there isn't any education post.
However, I've added the changes to hugo-toha/hugo-toha.github.io #253

@hossainemruz
Copy link
Member

Hi @BernatBC, Thank you for the PR. We can not change the configuration format for extraCurricularActivities. That will break existing user's site. Instead, we can support markdown syntax in the list. For example, user can specify the list with URL as below:

  extracurricularActivities:
  - [Example extracurricular activity with url]("https://www.example.com")
  - Example extracurricular activity no url

Then, in the list we can just pipe the content to markdownify to render this link. For example:

<li>{{ . | markdownify }}</li>

This will keep backward compatibility as well as support providing URL.

@BernatBC
Copy link
Member Author

BernatBC commented Jul 3, 2023

Hi hossainemruz thanks for repplying. I'll apply these changes. I didn't know that was possible, but it's a better option as it won't break this section.

@BernatBC
Copy link
Member Author

BernatBC commented Jul 3, 2023

This feature is ready to merge

@kodiakhq kodiakhq bot merged commit 9a75909 into hugo-toha:main Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants