Support commenting using giscus
#543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hossainemruz
requested changes
Feb 28, 2022
There was a problem hiding this comment.
Thank you @Rihoj. Looks good to me. Just a little change. Can you please acknowledge the comments?
update category default to General
hossainemruz
approved these changes
Feb 28, 2022
|
Thank you @Rihoj . Looks good to me. Would you like to have a PR in guide repo? I can merge this PR. |
hossainemruz
changed the title
hossainemruz
changed the title
giscus
|
@hossainemruz I am currently working on the guide PR. Since the structure was a single page for Analytics and Comments, I am working on detailing the whole page out, so it will be a little longer as I am not always elegant with my words. |
|
Yes. It will be good idea to separate the analytics and comment post. |
Rihoj
added a commit
to Rihoj/guides
that referenced
this pull request
Feb 28, 2022
hossainemruz
pushed a commit
to Rihoj/guides
that referenced
this pull request
Mar 15, 2022
|
I'm unable to see comments on my website following these instructions for giscus. Any ideas what could have gone wrong? |
|
Switched to utteranc and it still doesn't work... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #536
Description
Adds Giscus support
I do think a guide post should be added, but I wanted to make sure you like how this is done before I start writing out a post. (Unless someone else wants to write it)
Test Evidence