-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: customMenus in footer #513
Conversation
Show customMenu links also in footer. In `config.yaml`, - `params.footer.enable` is `true` to show the footer at all - `params.footer.navigation.enable` is `true` to show navigation items in the footer - `params.footer.navigation.customMenus.enable` is `true` to show customMenu items Example: ``` params: footer: enable: true navigation: enable: true customMenus: enable: true ``` In `data/<language>/site.yaml`, - `customMenus` must contain at least one entry with `showOnFooter: true` Example: ``` customMenus: - name: Imprint url: posts/imprint showOnFooter: true ```
@stueja I think we should avoid another extra layer of nesting in the footer. We can just specify, params:
footer:
enable: true
navigation:
enable: true
customMenus: true Also, do we really need |
Some items might not be wished in the top navbar, e. g. imprint or GDPR declaration or other. This was my thought. |
Ok. That's a valid use case. I will review the PR soon. Can you please acknowledge the nesting issue on
Sorry, if I disappointed you. We have to keep balance between features and maintainability. If there are too many moving parts, chances are something will break in every release. That's why we have to decide whether a use-case is worth or not to take the burden. |
Absolutely no disappointment on my side! I just wanted to say that I don't have hard feelings if a PR is not merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally like this change, and it looks like the nested issue mentioned was taken care of. Is there any way we could tie this to a change to https://github.com/hugo-toha/guides and https://toha-guides.netlify.app/posts/configuration/site-parameters/#add-custom-menus to try to keep the documentation up to date?
@Rihoj Thank you for reviewing. I am looking for a spare time to update those guides before merging this PR. It would be greatly appreciated if you can send a PR for the guides. I can merge this PR then. |
Update documentation for hugo-toha/toha#513 and hugo-toha/toha#514
Update documentation for hugo-toha/toha#513 and hugo-toha/toha#514 Co-authored-by: stueja <[email protected]> Co-authored-by: Emruz Hossain <[email protected]>
Show customMenu links also in footer.
In
config.yaml
,params.footer.enable
istrue
to show the footer at allparams.footer.navigation.enable
istrue
to show navigation itemsin the footer
params.footer.navigation.customMenus.enable
istrue
to showcustomMenu items
Example:
In
data/<language>/site.yaml
,customMenus
must contain at least one entry withshowOnFooter: true
Example:
Issue
Description
Test Evidence