Disable logo by default + add logo only if the user provide it #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's keep logo enabled by default. We can have a parameter to disable it. Or, if the logos are not provided, then disable it instead of defaulting to theme logo. |
|
Seems reasonable. I will see when I can work on this. |
hossainemruz
approved these changes
Jun 5, 2021
There was a problem hiding this comment.
Thank you @Kaligule . I have made some changes to the PR. Now, the logo will be added only if the user provide it. It won't default to theme logo anymore.
Signed-off-by: hossainemruz <[email protected]>
Signed-off-by: hossainemruz <[email protected]>
hossainemruz
changed the title
hossainemruz
changed the title
Signed-off-by: hossainemruz <[email protected]>
hossainemruz
approved these changes
Jun 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
There is no related issue.
Description
Logos are not shown by default. (I figured this is a sensible default because most people don't have a personal logo. Especially not in different light/dark version. But I would be happy to discuss this point.
Logos can be enabled again with (toml)
or (yaml)
Test Evidence