Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update [email protected] #21

Closed
wants to merge 2 commits into from
Closed

Update [email protected] #21

wants to merge 2 commits into from

Conversation

jmannanc
Copy link

This PR updates readable-stream to 3.0.2 to work on fixing an NPM bug. See npm/cli#59

.travis.yml Outdated
- "0.12"
- "6.0"
- "8.0"
- "10.0"
- "iojs"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should remove this one as well.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@mafintosh
Copy link
Collaborator

Hold on merging this. Because readable-stream@3 defines a getter on .destroyed which we use internally for something else this is not trivial to add. I need to investigate this a bit more.

@jmannanc jmannanc closed this Sep 16, 2019
@timwis timwis mentioned this pull request May 11, 2020
@seriousme
Copy link

@mafintosh is this module dead ?
It hasn't been updated since 15 Aug 2016, and its travis config still holds io.js :-X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants