Use Buffer.from instead of new Buffer

[TehShrike]

The buffer constructor has been deprecated since node 6, which fell out of maintenance a good while ago.

atob-lite was similarly updated a couple years ago: https://github.com/hughsk/atob-lite/blob/master/atob-node.js

[gr2m]

ping ☝️

[Richienb]

@hughsk ☝️

[Richienb]

@hughsk

[gr2m]

@Richienb maybe we should maintain our own btoa polyfill lib within @node-fetch

[Richienb]

@gr2m I just created https://github.com/node-fetch/btoa-lite. Any idea who owns the node-fetch npm org?

[gr2m]

I assume @bitinn

[Richienb]

// @bitinn

[Richienb]

@bitinn

[bitinn]

jimmy warting should have publish right for node-fetch on npm, but I don’t know why you need publishing right on node-fetch to publish this module though? Plus you are the admin for the node-fetch org, right? Plus plus we don’t use btoa-lite directly in node-fetch? All in all, I am super confused, and 2 year late ;)

…

Sent from my iPhone

On Apr 21, 2022, at 12:50, Richie Bendall ***@***.***> wrote:  @bitinn — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.

[Richienb]

@gr2m suggested to publish the module as @node-fetch/btoa-lite and assumes that you are the person with the publish perms.

[bitinn]

@gr2m suggested to publish the module as @node-fetch/btoa-lite and assumes that you are the person with the publish perms.

I think we never had a npm org, we publish module individually (see node-fetch and fetch-blob). Jimmy owns publishing right for both of them now. For btoa-lite, you can certainly help to setup a npm org :)