Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip Fuyu from test_generate #35246

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Conversation

nhamanasu
Copy link
Contributor

@nhamanasu nhamanasu commented Dec 12, 2024

What does this PR do?

skip Fuyu model from test_prompt_lookup_decoding_matches_greedy_search to fix tests_generate's failure.

Backgrounds

Recently, test_generate in CircleCI fails due to FuyuModelTest.
([reference] tests_generate - Failed)

The direct cause is RuntimeError: The size of tensor a (2) must match the size of tensor b (0) at non-singleton dimension 1, perhaps caused by eos_token_id should consist of positive integers, but is tensor([-1]). Your generation will not stop until the maximum length is reached. Depending on other flags, it may even crash.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@nhamanasu nhamanasu marked this pull request as ready for review December 12, 2024 17:32
@nhamanasu nhamanasu mentioned this pull request Dec 12, 2024
5 tasks
@Rocketknight1
Copy link
Member

cc @ydshieh

@nhamanasu
Copy link
Contributor Author

@zucchini-nlp
Copy link
Member

Fuyu skips the other assisted decoding methods due to specific way inputs have to be handled, afaik. So I'll be ok with skipping it, if @ydshieh agrees

Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the PR 🙏

@ydshieh ydshieh merged commit 3d213b5 into huggingface:main Dec 13, 2024
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants